Skip to content

Conversation

@gsaluja9
Copy link
Contributor

@gsaluja9 gsaluja9 commented Nov 19, 2024

Use HMDB51 to train movinet. While this is an end to end example that works, it needs the following addressed to make it to the docs.

  • Complete the README.md
  • Add the wget dependencies (and test on colab).
  • Improve markdown in the notebook.
  • Debug why it won't work in mac
  • Clean up.

@gsaluja9
Copy link
Contributor Author

The problem on Mac was multiprocessing in pytorch dataloader. DL with num_workers lets the DL to iterate, as it runs in the main process.

"""
Dataset used to parallelize the reading of the timestamps
of a list of videos, given their paths in the filesystem.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is not explaining much. but you did say you plan to add more comments. so that's good. if we need a class hierarchy diagram, maybe that helps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually, this is the exact doc string of the pytorch version which we have overriden. Let me change it to why this is needed instead.

"id": "c9b8f6e9-668c-4c4b-81dd-5fcfb7956d51",
"metadata": {},
"source": [
"# Classification with a vanilla model vs trained model.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"# Classification with a vanilla model vs trained model.\n",
"# Activity Recognition on Videos Stored in ApertureDB\n",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am debating if it should address finetuninig in the title but I dont suppose we show trianing example, do we?

"def get_common():\n",
" \"\"\"\n",
" Just common parameters.\n",
" Applies to the training and data loading sections.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code does need more comments but its looking good. Are you planning to land the READMe in docs?

"id": "4f7045eb-228a-4019-93a1-7fe69ee1068a",
"metadata": {},
"source": [
"## Make a model from trained movinet with hmdb51"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a model?

"id": "a7c4bda9",
"metadata": {},
"source": [
"## See the shape of the tensor passsed through model.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I Don't follow what seeing the shape means

@@ -0,0 +1,41 @@
# Using HMDB51 to train movinet.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have more context ?

import os
import subprocess

from aperturedb.ParallelLoader import ParallelLoader
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file? as in, needs comments or mention in readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants